Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue 114] - Adding the PostgreSql template provisioner (for legacy … #115

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Dec 5, 2023

Description

Fix #114

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@fabiobrz fabiobrz force-pushed the add.pgsql-template-prov branch from dcb4b23 to c459236 Compare December 9, 2023 18:26
@fabiobrz
Copy link
Member Author

fabiobrz commented Dec 9, 2023

/retest

1 similar comment
@fabiobrz
Copy link
Member Author

/retest

@fabiobrz
Copy link
Member Author

fabiobrz commented Dec 10, 2023

Hi @marekkopecky - the CI checks can be taken as successful, and the PR is ready for review.
The only failure (Kafka Operator provisioner test) is tracked separately by #117

@fabiobrz
Copy link
Member Author

@fabiobrz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/intersmash-e2e 5037f6b link true /test intersmash-e2e
ci/prow/prod-intersmash-e2e-prod 5037f6b link true /test prod-intersmash-e2e-prod

Full PR test history. Your PR dashboard.

Hi @marekkopecky - this CI check run is good. The failure in the prod job is expected and the one in the community job is a randomly intermittent failure.
Feel free to let me know whether anything else is needed here, or to merge the changes right away.

@fabiobrz fabiobrz force-pushed the add.pgsql-template-prov branch from 5037f6b to 3316aae Compare December 11, 2023 15:02
Copy link

openshift-ci bot commented Dec 11, 2023

@fabiobrz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/prod-intersmash-e2e-prod 3316aae link true /test prod-intersmash-e2e-prod

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Collaborator

@marekkopecky marekkopecky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM.

@marekkopecky
Copy link
Collaborator

It seems that there is no option to merge this PR, I see:

Required statuses must pass before merging
All required statuses and check runs on this pull request must run successfully to enable automatic merging."

Can you please double-check?

@fabiobrz
Copy link
Member Author

It seems that there is no option to merge this PR, I see:

Required statuses must pass before merging
All required statuses and check runs on this pull request must run successfully to enable automatic merging."

Can you please double-check?

Thanks @marekkopecky - I checked and will try to update the settings in the future. For now I'll merge this since you approved.

Thanks!

@fabiobrz fabiobrz merged commit cf115a2 into Intersmash:main Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a PostgreSql template based provisioner.
2 participants