Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Socket.NoDelay option to configureOutboundSocket #4762

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

AndrewWestberg
Copy link
Contributor

Description

It looks like an oversight to not set the Socket.NoDelay option for outgoing sockets. This PR corrects that.

Checklist

  • Branch
    • Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@AndrewWestberg AndrewWestberg requested a review from coot as a code owner January 3, 2024 23:08
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is misnamed, it's only used by connectTo which is used by some client applications. The right step is to actually remove it and define it locally in connectTo.

@coot coot closed this Jan 11, 2024
@coot
Copy link
Contributor

coot commented Jan 11, 2024

Anyway, @AndrewWestberg thanks for the PR, and sorry for confusing you.

@coot coot reopened this Jan 11, 2024
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it first, before moving the function to right place.

@coot coot enabled auto-merge January 11, 2024 13:47
@coot coot added this pull request to the merge queue Jan 11, 2024
Merged via the queue into IntersectMBO:master with commit 8a2b5ca Jan 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants