Merge pull request #5060 from IntersectMBO/mwojtowicz/fix-rethrow-policy

Fix rethrow policy
IntersectMBO · Feb 3, 2025 · 2335595 · 2335595
2 parents f4d05d1 + b2ba2e9
commit 2335595
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/ouroboros-network/CHANGELOG.md b/ouroboros-network/CHANGELOG.md
@@ -21,6 +21,7 @@
 * Use `LocalRootConfig` instead of a tuple.
 * Extended `LocalRootConfig` with `diffusionMode :: DiffusionMode` field.
 * Added `diConnStateSupply` record field to `Ouroboros.Network.Diffusion.P2P.Interfaces`.
+* UnknownMiniProtocol error should not crash the node
 
 ### Non-Breaking changes
 

diff --git a/ouroboros-network/src/Ouroboros/Network/Diffusion/P2P.hs b/ouroboros-network/src/Ouroboros/Network/Diffusion/P2P.hs
@@ -745,11 +745,8 @@ runM Interfaces
           Nothing -> mempty)
       <>
       RethrowPolicy (\ctx err -> case  (ctx, fromException err) of
-                        -- mux unknown mini-protocol errors on the outbound
-                        -- side are fatal, since this is misconfiguration of the
-                        -- ouroboros-network stack.
                         (OutboundError, Just Mx.UnknownMiniProtocol {})
-                          -> ShutdownNode
+                          -> ShutdownPeer
                         _ -> mempty)