LedgerDB: prune on garbage collection instead of on every change #1513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amesgen
force-pushed
the
amesgen/ledgerdb-garbage-collect-states
branch
2 times, most recently
from
8b48bb3 to
045f1cc
Compare
It is not necessary to perform the garbage collection of the LedgerDB and the map of invalid blocks in the same STM transaction. In the past, this was important, but it is not anymore, see #1507.
No behavioral change, just a refactoring by extracting common parts; convenient for follow-up changes
regarding the previous few commits
amesgen
force-pushed
the
amesgen/ledgerdb-garbage-collect-states
branch
from
2037a0f to
2fc8d06
Compare
This ensures that the underlying handle isn't garbage-collected, as we only schedule a garbage collection for all states with a slot number strictly smaller than the immutable tip. Also, a very small benefit is that we get (slightly) faster replay on node startup.
amesgen
force-pushed
the
amesgen/ledgerdb-garbage-collect-states
branch
2 times, most recently
from
c3a08d1 to
13e5533
Compare
This is used in db-analyser only, where everything happens synchronously in a single thread, so it is fine to immediately prune. V1 already does this.
amesgen
force-pushed
the
amesgen/ledgerdb-garbage-collect-states
branch
from
13e5533 to
68402ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for #1424
Targets #1516 as the changes in this PR fix a bug revealed by the fix in #1516
TODO:
DbChangelog/LedgerSeq.