-
Notifications
You must be signed in to change notification settings - Fork 27
UTxO-HD for node 10.4 #1412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
UTxO-HD for node 10.4 #1412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b51d07
to
fcba3a3
Compare
e8675fc
to
695c107
Compare
jasagredo
commented
Apr 4, 2025
ouroboros-consensus-cardano/src/byron/Ouroboros/Consensus/Byron/ByronHFC.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-cardano/src/byron/Ouroboros/Consensus/Byron/ByronHFC.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Eras.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Node/Serialisation.hs
Show resolved
Hide resolved
db8f8f5
to
620a677
Compare
The Check references CI job is expected to fail because we reference new pages in the website that still do not exist online. |
9 tasks
amesgen
approved these changes
Apr 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formally approving; the actual review work happened in #1267
This commit puts together all the changes for UTxO-HD. It is annoying that it is such a big commit but due to the numerous rebases, conflicts arose at each single commit thus we reverted to put together everything in one commit to minimize the conflict-resolving work. For a super high-level description of UTxO-HD, the changelogs give brief indications. For a more low-level description, check the new website documents. This commit is the result of the joint effort by many people that are or were part of the Consensus team and neighbour teams that made contributions be those in design, testing or implementing some parts of UTxO-HD, who I would like to acknowledge their participation by adding them as co-authors here, in no particular order. Co-authored-by: Joris Dral <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Nick Frisby <[email protected]> Co-authored-by: Damian Nadales <[email protected]> Co-authored-by: Fraser Murray <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Renate Eilers <[email protected]> Co-authored-by: Yogesh Sajanikar <[email protected]> Co-authored-by: Bart Frenk <[email protected]> Co-authored-by: Pawel Szulc <[email protected]> Co-authored-by: Arnaud Bailly <[email protected]> Co-authored-by: Douglas Wilson <[email protected]> Co-authored-by: Duncan Coutts <[email protected]> Co-authored-by: Alexey Kuleshevich <[email protected]> Co-authored-by: Jared Corduan <[email protected]>
- Re-format files - Remove warning on unused import - Update hackageNix in flake.lock
It is unused
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 19, 2025
Suppose that `s0 < s1 < s2` are slots with blocks in the ImmutableDB, and no other slot `s` with `s0 < s < s2` has a block, and suppose that we run `db-analyser --store-ledger s2`. It is now expected that we store a ledger snapshot for slot `s2`, which was the case before #1412. However: - With `--v1-in-mem` or `--lmdb`, we store a ledger snapshot for slot `s1`. - With `--v2-in-mem`, we store a ledger snapshot for slot `s0`. This PR fixes two unrelated bugs causing this (one specific to the V2 LedgerDB), see the individual commits. Now, in all cases, we store a ledger snapshot for slot `s2`. Applied the `no changelog` label as only testing/internal code is affected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement UTxO-HD on top of the latest main.
Changelog fragments give a super-high-level description. Documentation on the website goes a bit more in depth.