NodeKernel: expose getBlockchainTime #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgmeier
requested review from
nfrisby,
jasagredo,
amesgen,
fraser-iohk,
dnadales and
geo2a
as code owners
mgmeier
force-pushed
the
mkarg/expose-btime
branch
from
536cb6c to
c8cc98d
Compare
|
As I have no clue how I get CI to pass the changelog check without bumping the package version, I've added the "no changelog" label. |
mgmeier
force-pushed
the
mkarg/expose-btime
branch
from
c8cc98d to
6a23c1d
Compare
jasagredo
force-pushed
the
mkarg/expose-btime
branch
from
6a23c1d to
2d2f816
Compare
jasagredo
force-pushed
the
mkarg/expose-btime
branch
from
2d2f816 to
4efdfb6
Compare
jasagredo
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes the blockchain time in the node kernel.
This tiny change is a requirement for the "periodic metrics tracer" feature (cf. IntersectMBO/cardano-node#6076), which has already shown promising performance improvements in benchmarks.