Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hackage rawlock #1290

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Use hackage rawlock #1290

merged 1 commit into from
Oct 23, 2024

Conversation

jasagredo
Copy link
Contributor

Replace the in-tree RAWLock with the hackage version, which is safer in presence of exceptions.

@jasagredo
Copy link
Contributor Author

The nix-based actions will fail because hackage.nix is not yet updated.

amesgen
amesgen approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tomorrow once hackage.nix got updated 👍

ouroboros-consensus/changelog.d/js-rawlock.md Outdated Show resolved Hide resolved
@jasagredo jasagredo force-pushed the js/hackage-rawlock branch 2 times, most recently from c4a525d to d79a61a Compare October 23, 2024 12:13
@jasagredo jasagredo added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 8387269 Oct 23, 2024
18 checks passed
@jasagredo jasagredo deleted the js/hackage-rawlock branch October 23, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amesgen amesgen amesgen approved these changes

@nfrisby nfrisby Awaiting requested review from nfrisby nfrisby is a code owner

@fraser-iohk fraser-iohk Awaiting requested review from fraser-iohk fraser-iohk is a code owner

@dnadales dnadales Awaiting requested review from dnadales dnadales is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasagredo @amesgen