Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#710] fix displaying modals to not block signing transactions #711

Merged
merged 1 commit into from
Apr 16, 2024
Merged

[#710] fix displaying modals to not block signing transactions #711

merged 1 commit into from
Apr 16, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • fix displaying modals to not block signing transactions

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Apr 12, 2024 that may be closed by this pull request
Fix displaying modals to not block signing transactions with metadata #710
Closed
@MSzalowski MSzalowski force-pushed the fix/710-fix-displaying-modals-to-not-block-signing-transactions-with-metadata branch from 65d228d to 3266728 Compare April 15, 2024 14:56
@MSzalowski MSzalowski merged commit 411db90 into develop Apr 16, 2024
6 checks passed
@MSzalowski MSzalowski deleted the fix/710-fix-displaying-modals-to-not-block-signing-transactions-with-metadata branch April 16, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanJaroszczak JanJaroszczak JanJaroszczak approved these changes

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix displaying modals to not block signing transactions with metadata
2 participants
@MSzalowski @JanJaroszczak