[#220] drep list #559
Merged
[#220] drep list #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdyczka
requested review from
MSzalowski,
Sworzen1,
JanJaroszczak and
kickloop
as code owners
This was
linked to
issues
Mar 26, 2024
jdyczka
force-pushed
the
feat/220-drep-list
branch
from
b42022a
to
1ab56a2
Compare
jdyczka
force-pushed
the
feat/99-drep-directory
branch
from
508df0e
to
51bee96
Compare
Sworzen1
suggested changes
Mar 26, 2024
| ); | ||
|
|
||
| const getBgColor = (status: Status): string => { | ||
| switch (status) { |
There was a problem hiding this comment.
Insead of switch
{
Active:successGreen.c200,
Inactive:cyan.c100,
Retired:errorRed.c100
}[status]
| > | ||
| {t("delegate")} | ||
| </Button> | ||
| {!isConnected |
There was a problem hiding this comment.
is it not the same label ?, but just different action ?
There was a problem hiding this comment.
left a comment on figma
| isConnected={isConnected} | ||
| isSelected={currentDelegation === "drep_always_abstain"} | ||
| onClickDelegate={() => delegate("abstain")} | ||
| onClickInfo={() => { }} |
There was a problem hiding this comment.
what Info should do ?, can you leave commet ?
There was a problem hiding this comment.
left a comment on figma
| addSuccessAlert(t("alerts.delegate.success")); | ||
| } | ||
| } catch (error) { | ||
| addErrorAlert(t("alerts.delegate.failed")); |
There was a problem hiding this comment.
add sentry capture expction
- refactor determining StatusPill colors - add Sentry.captureException on delegate error
Sworzen1
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Checklist