Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infra/test chores #1666

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Infra/test chores #1666

merged 2 commits into from
Aug 8, 2024

Conversation

mesudip
Copy link
Contributor

@mesudip mesudip commented Aug 2, 2024

List of changes

  • add VITE_METADATA_API_URL env variable to frontend build

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski
Copy link
Contributor

LGTM 👍

@mesudip mesudip mentioned this pull request Aug 6, 2024
Closed
@mesudip mesudip merged commit 90defa8 into develop Aug 8, 2024
1 check failed
@mesudip mesudip deleted the infra/test-chores branch August 8, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mesudip @MSzalowski