Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1093] return 0 drep voting power instead of throwing 500 #1405

Merged
merged 1 commit into from
Jun 23, 2024
Merged

[#1093] return 0 drep voting power instead of throwing 500 #1405

merged 1 commit into from
Jun 23, 2024

Conversation

jankun4
Copy link
Contributor

@jankun4 jankun4 commented Jun 23, 2024

List of changes

Fix

  • drep/get-voting-power no longer throws error 500 for non-existent dreps

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@jankun4 jankun4 linked an issue Jun 23, 2024 that may be closed by this pull request
Endpoint drep/get-voting-power/{drepid} - error 500 when passing Hex DRep ID (Pub DRep Key hash) instead of Bech32 DRep ID (Pub DRep Key hash) #1093
Closed
@jankun4 jankun4 marked this pull request as ready for review June 23, 2024 15:07
@jankun4 jankun4 merged commit fb643d0 into develop Jun 23, 2024
0 of 2 checks passed
@jankun4 jankun4 deleted the 1093-endpoint-drepget-voting-powerdrepid-error-500-when-passing-hex-drep-id-pub-drep-key-hash-instead-of-bech32-drep-id-pub-drep-key-hash branch June 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jankun4 @MSzalowski