Skip to content

Commit

Permalink
Merge pull request #1647 from IntersectMBO/chore/make-frontend-build-…
Browse files Browse the repository at this point in the history
…arguments-mandatory

chore: make all the frontend build arguments mandatory
  • Loading branch information
MSzalowski authored Jul 31, 2024
2 parents ef37cd1 + 7bccd0a commit a6c38ba
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ changes.
- Change link to propose a governace action docs [Issue 1132](https://github.com/IntersectMBO/govtool/issues/1132)
- Change link to docs regarding DReps [Issue 1130](https://github.com/IntersectMBO/govtool/issues/1130)
- Change link to view governance actions docs [Issue 1131](https://github.com/IntersectMBO/govtool/issues/1131)
- Make all the frontend build arguments mandatory [Issue 1642](https://github.com/IntersectMBO/govtool/issues/1642), [Issue 1643](https://github.com/IntersectMBO/govtool/issues/1643)

## [sancho-v1.0.11](https://github.com/IntersectMBO/govtool/releases/tag/sancho-v1.0.11) 2024-07-30

Expand Down
12 changes: 12 additions & 0 deletions govtool/frontend/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,19 @@ ARG VITE_USERSNAP_SPACE_API_KEY
ARG VITE_IS_PROPOSAL_DISCUSSION_FORUM_ENABLED='true'
ARG VITE_PDF_API_URL

# Ensure all required build arguments are set
RUN \
: "${VITE_APP_ENV:?Build argument VITE_APP_ENV is not set}" && \
: "${VITE_BASE_URL:?Build argument VITE_BASE_URL is not set}" && \
: "${VITE_GTM_ID:?Build argument VITE_GTM_ID is not set}" && \
: "${VITE_NETWORK_FLAG:?Build argument VITE_NETWORK_FLAG is not set}" && \
: "${VITE_SENTRY_DSN:?Build argument VITE_SENTRY_DSN is not set}" && \
: "${NPMRC_TOKEN:?Build argument NPMRC_TOKEN is not set}" && \
: "${VITE_USERSNAP_SPACE_API_KEY:?Build argument VITE_USERSNAP_SPACE_API_KEY is not set}" && \
: "${VITE_IS_PROPOSAL_DISCUSSION_FORUM_ENABLED:?Build argument VITE_IS_PROPOSAL_DISCUSSION_FORUM_ENABLED is not set}"

ENV NODE_OPTIONS=--max_old_space_size=8192

WORKDIR /src

# Set npm configuration settings using environment variables
Expand Down

0 comments on commit a6c38ba

Please sign in to comment.