Merge pull request #1032 from IntersectMBO/1031-update-ga-links-type

[#1031] Update GA links type
IntersectMBO · May 15, 2024 · 7242721 · 7242721
2 parents d7545cb + 4d6ab36
commit 7242721
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/govtool/frontend/src/components/molecules/GovernanceActionDetailsCardLinks.tsx b/govtool/frontend/src/components/molecules/GovernanceActionDetailsCardLinks.tsx
@@ -9,7 +9,7 @@ import { LinkWithIcon } from "@molecules";
 export const GovernanceActionDetailsCardLinks = ({
   links,
 }: {
-  links?: string[];
+  links?: GovernanceActionLink[];
 }) => {
   const { isMobile } = useScreenDimension();
   const { t } = useTranslation();
@@ -43,13 +43,13 @@ export const GovernanceActionDetailsCardLinks = ({
         >
           {links.map((link) => (
             <LinkWithIcon
-              key={link}
-              label={link}
+              key={link.uri}
+              label={link.uri}
               onClick={() => {
                 openModal({
                   type: "externalLink",
                   state: {
-                    externalLink: link,
+                    externalLink: link.uri,
                   },
                 });
               }}

diff --git a/govtool/frontend/src/components/organisms/GovernanceActionDetailsCard.tsx b/govtool/frontend/src/components/organisms/GovernanceActionDetailsCard.tsx
@@ -24,7 +24,7 @@ type GovernanceActionDetailsCardProps = {
   motivation?: string;
   rationale?: string;
   yesVotes: number;
-  links?: string[];
+  links?: GovernanceActionLink[];
   govActionId: string;
   isDataMissing: boolean | MetadataValidationStatus;
   isDashboard?: boolean;

diff --git a/govtool/frontend/src/components/organisms/GovernanceActionDetailsCardData.tsx b/govtool/frontend/src/components/organisms/GovernanceActionDetailsCardData.tsx
@@ -26,7 +26,7 @@ type GovernanceActionDetailsCardDataProps = {
   isInProgress?: boolean;
   isOneColumn: boolean;
   isSubmitted?: boolean;
-  links?: string[];
+  links?: GovernanceActionLink[];
   motivation?: string;
   rationale?: string;
   title?: string;

diff --git a/govtool/frontend/src/types/global.d.ts b/govtool/frontend/src/types/global.d.ts
@@ -75,4 +75,10 @@ declare global {
 
   type ArrayElement<ArrayType extends readonly unknown[]> =
     ArrayType extends readonly (infer ElementType)[] ? ElementType : never;
+
+  type GovernanceActionLink = {
+    "@type": string;
+    label: string;
+    uri: string;
+  };
 }