Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From dev to QA #85

Merged
merged 1 commit into from
Jan 29, 2025
Merged

From dev to QA #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pdf-ui/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
As a minor extension, we also keep a semantic version for the `UNRELEASED`
changes.

## [v0.5.10](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.11) 2025-01-29
### Fixed
- Proposal rendering fix

## [v0.5.10](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.10) 2025-01-29
### Fixed
- Some typo fixes.
Expand Down
2 changes: 1 addition & 1 deletion pdf-ui/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pdf-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@intersect.mbo/pdf-ui",
"version": "0.5.10",
"version": "0.5.11",
"description": "Proposal discussion ui",
"main": "./src/index.js",
"exports": {
Expand Down
55 changes: 10 additions & 45 deletions pdf-ui/src/pages/ProposedGovernanceActions/SingleGovernanceAction/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,8 +1049,6 @@ const SingleGovernanceAction = ({ id }) => {
</Typography>
<ReactMarkdown>
{showFullText || !maxLength ? AbstractMarkdownText : truncatedText}


</ReactMarkdown>
{!showFullText && maxLength && totalCharLength > maxLength && (
<Button
Expand All @@ -1071,69 +1069,37 @@ const SingleGovernanceAction = ({ id }) => {
</Button>)}
</Box>
{showFullText && (
<>

<Box mt={4}>
<Typography
variant='caption'
sx={{
color: (theme) => theme?.palette?.text?.grey,
}}
>
Motivation
Motivation
</Typography>
<ReactMarkdown
components={{
p(props) {
const { children } = props;
return (
<Typography
variant='body2'
data-testid='motivation-content'
style={{
wordWrap: 'break-word',
}}
>
{children}
</Typography>
);
},
}}
>
<ReactMarkdown>
{proposal?.attributes?.content
?.attributes?.prop_motivation || ''}
</ReactMarkdown>
</Box>
</Box>)}
{showFullText && (
<Box mt={4}>
<Typography
variant='caption'
sx={{
color: (theme) => theme?.palette?.text?.grey,
}}
>
Rationale
Rationale
</Typography>
<ReactMarkdown
components={{
p(props) {
const { children } = props;
return (
<Typography
variant='body2'
data-testid='rationale-content'
style={{
wordWrap: 'break-word',
}}
>
{children}
</Typography>
);
},
}}
>
<ReactMarkdown>
{proposal?.attributes?.content
?.attributes?.prop_rationale || ''}
</ReactMarkdown>
</Box>
</Box>)}
{showFullText && (
<Button
variant="text"
onClick={() => setShowFullText(!showFullText)}
Expand All @@ -1149,8 +1115,7 @@ const SingleGovernanceAction = ({ id }) => {
}}
>
{showFullText ? 'Show less' : 'Read more'}
</Button>
</>
</Button>
)}
{proposal?.attributes?.content?.attributes
?.proposal_links?.length > 0 && (
Expand Down
Loading