Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From Dev to QA #54

Merged
merged 3 commits into from
Dec 6, 2024
Merged

From Dev to QA #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b679e41
Fix test id names on review
nebojsajsimic Dec 6, 2024
baeeac9
Version change and description
nebojsajsimic Dec 6, 2024
3f396de
Merge pull request #53 from IntersectMBO/3rd-fix-for-#2438
nebojsact Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pdf-ui/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
As a minor extension, we also keep a semantic version for the `UNRELEASED`
changes.

## [v0.5.5](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.5) 2024-12-06

### Added -
### Fixed -
- Fix display Stake Address and Amount in Draft [Issue #2438](https://github.com/IntersectMBO/govtool/issues/2438)
- Fix Test Id names in review form [Issue #2437](https://github.com/IntersectMBO/govtool/issues/2437)
### Changed -
### Removed -

## [v0.5.4](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.4) 2024-12-05

### Added -
Expand Down
2 changes: 1 addition & 1 deletion pdf-ui/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pdf-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@intersect.mbo/pdf-ui",
"version": "0.5.4",
"version": "0.5.5",
"description": "Proposal discussion ui",
"main": "./src/index.js",
"exports": {
Expand Down
8 changes: 5 additions & 3 deletions pdf-ui/src/components/CreationGoveranceAction/Step2.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,10 @@ const Step2 = ({
setLoading(true);
try {
const governanceActionTypeList = await getGovernanceActionTypes();

const mappedData = governanceActionTypeList?.data?.map((item) => ({
value: item?.id,
label: item?.attributes?.gov_action_type_name,
}));

setGovernanceActionTypes(mappedData);
} catch (error) {
console.error(error);
Expand Down Expand Up @@ -118,6 +116,11 @@ const Step2 = ({
fetchGovernanceActionTypes();
}, []);

useEffect(()=>{
setSelectedGovActionName(governanceActionTypes.find(
(option) => option?.value === +proposalData?.gov_action_type_id
)?.label || '')
},[governanceActionTypes])
return (
<Card>
<CardContent
Expand Down Expand Up @@ -363,7 +366,6 @@ const Step2 = ({
: 'rationale-helper',
}}
/>

{selectedGovActionName === 'Treasury' ? (
<>
<Box
Expand Down
4 changes: 2 additions & 2 deletions pdf-ui/src/components/CreationGoveranceAction/Step3.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ const Step3 = ({
<Typography
variant='body1'
gutterBottom
data-testid='receiving-address-${index}-content'
data-testid={`receiving-address-${index}-content`}
>
{withdrawal.prop_receiving_address}
</Typography>
Expand All @@ -213,7 +213,7 @@ const Step3 = ({
<Typography
variant='body1'
gutterBottom
data-testid='amount-${index}-content'
data-testid={`amount-${index}-content`}
>
{withdrawal.prop_amount}
</Typography>
Expand Down
Loading