Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new transaction validations #26

Merged
merged 6 commits into from
Jan 27, 2025
Merged

Add new transaction validations #26

merged 6 commits into from
Jan 27, 2025

Conversation

elenabardho
Copy link
Collaborator

@elenabardho elenabardho commented Jan 22, 2025

List of changes

  • Add new validation checks
    -Check required signers in the transaction
    -Check transaction has one vote
    -Check there is no certificates in the transaction
    -Check if wallet and transaction are for the same network (mainnet || testnet)
    -Check if signature is part of the plutus data in output
    -Check if the ICC credentials are correct

@elenabardho elenabardho linked an issue Jan 24, 2025 that may be closed by this pull request
@Ryun1
Copy link
Member

Ryun1 commented Jan 24, 2025

Can we add also;

  • IF a validation has failed, dont let the user press the sign button

@Ryun1 Ryun1 marked this pull request as ready for review January 24, 2025 18:46
@elenabardho elenabardho force-pushed the feat/validation-checks branch from bcae377 to 0573334 Compare January 27, 2025 10:18
@Ryun1 Ryun1 merged commit 023d03c into v1.0 Jan 27, 2025
1 check passed
@Ryun1 Ryun1 deleted the feat/validation-checks branch January 27, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TODO - more transaction validation steps
2 participants