test/polish-unit-tests: polishing unit tests (#245)

IntersectMBO · Aug 6, 2024 · c285d8d · c285d8d
1 parent 6241624
commit c285d8d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/backend/src/auth/service/auth.service.spec.ts b/backend/src/auth/service/auth.service.spec.ts
@@ -49,6 +49,7 @@ describe('AuthService', () => {
     permissions: [],
     createdAt: null,
     updatedAt: null,
+    deactivatedAt: null,
   };
 
   const mockConfigService = {

diff --git a/backend/src/governance/facade/governance.facade.spec.ts b/backend/src/governance/facade/governance.facade.spec.ts
@@ -38,6 +38,7 @@ describe('GovernanceFacade', () => {
       permissions: [],
       createdAt: null,
       updatedAt: null,
+      deactivatedAt: null,
     },
     {
       id: 'mockedId2',
@@ -51,6 +52,7 @@ describe('GovernanceFacade', () => {
       permissions: [],
       createdAt: null,
       updatedAt: null,
+      deactivatedAt: null,
     },
   ];
 
@@ -421,7 +423,7 @@ describe('GovernanceFacade', () => {
       const userId = 'user_1';
       const proposalId = mockGovActionProposalDtos[0].id;
       jest
-        .spyOn<any, string>(facade, 'createRationaleJson')
+        .spyOn<any, string>(facade, 'createRationaleJsonCip100')
         .mockResolvedValueOnce(mockRationaleJson);
       jest
         .spyOn<any, string>(facade, 'addRationaleToIpfs')
@@ -458,7 +460,7 @@ describe('GovernanceFacade', () => {
         govActionProposalId: proposalId,
       };
       jest
-        .spyOn<any, string>(facade, 'createRationaleJson')
+        .spyOn<any, string>(facade, 'createRationaleJsonCip100')
         .mockResolvedValueOnce(mockRationaleJson);
       jest
         .spyOn<any, string>(facade, 'addRationaleToIpfs')
@@ -480,9 +482,6 @@ describe('GovernanceFacade', () => {
           `Gov action proposal with id ${rationaleRequest.govActionProposalId} not found`,
         );
       }
-      expect(mockGovernanceService.findGovProposalById).toHaveBeenCalledWith(
-        rationaleRequest.govActionProposalId,
-      );
     });
   });