Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for timeout of gov actions #5873

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Add test for timeout of gov actions #5873

merged 2 commits into from
Jun 7, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Jun 4, 2024

Description

This PR tests that government actions expire if not ratified after more than govActionLifetime epochs.
This addresses this issue: #5594

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@palas palas self-assigned this Jun 4, 2024
@palas palas requested a review from a team as a code owner June 4, 2024 20:22
@palas palas linked an issue Jun 4, 2024 that may be closed by this pull request
Timing Out of Governance Actions #5594
Closed
carbolymer
carbolymer reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@palas palas changed the base branch from master to test-pparam-change-spo-fails June 6, 2024 19:32
Base automatically changed from test-pparam-change-spo-fails to master June 6, 2024 21:25
@palas palas added this pull request to the merge queue Jun 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 7, 2024
@palas palas added this pull request to the merge queue Jun 7, 2024
Merged via the queue into master with commit 4314990 Jun 7, 2024
24 checks passed
@palas palas deleted the test-gov-action-timeout branch June 7, 2024 02:20
Jimbo4350
Jimbo4350 reviewed Jun 7, 2024
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer left review comments

@Jimbo4350 Jimbo4350 Jimbo4350 left review comments

@smelc smelc smelc approved these changes

Assignees

@palas palas

Labels
cardano-testnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timing Out of Governance Actions
4 participants
@palas @carbolymer @smelc @Jimbo4350