Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP #5705

Closed
wants to merge 2 commits into from
Closed

WIP #5705

wants to merge 2 commits into from

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Mar 5, 2024

Description

Add your description here, if it fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@erikd erikd requested review from a team as code owners March 5, 2024 06:50
@erikd erikd marked this pull request as draft March 5, 2024 06:50
@erikd erikd self-assigned this Mar 5, 2024
@erikd erikd force-pushed the erikd/rm-git-rev branch 2 times, most recently from 13dfb39 to 4441438 Compare March 5, 2024 06:55
@erikd erikd closed this Mar 5, 2024
@erikd erikd reopened this Mar 5, 2024
@erikd erikd force-pushed the erikd/rm-git-rev branch 3 times, most recently from a8d0de6 to 17aaca8 Compare March 8, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant