Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bench profiles #5667

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Bench profiles #5667

merged 2 commits into from
Jul 12, 2024

Conversation

fmaste
Copy link
Contributor

@fmaste fmaste commented Feb 9, 2024

Description

A Haskell library to create workbench profiles and replace profiles definitions in jq.

Still not activated as workbench's default

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

Copy link

github-actions bot commented May 6, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label May 6, 2024
@github-actions github-actions bot removed the Stale label May 11, 2024
@fmaste fmaste force-pushed the bench-profiles branch 2 times, most recently from dba3a04 to 18ead58 Compare June 3, 2024 11:25
@fmaste fmaste force-pushed the bench-profiles branch 2 times, most recently from 0863de1 to d7ad2eb Compare June 10, 2024 13:37
@fmaste fmaste force-pushed the bench-profiles branch 3 times, most recently from 68b7a5d to 76b27f7 Compare June 22, 2024 13:02
@fmaste fmaste force-pushed the bench-profiles branch 3 times, most recently from 04ab7a7 to 9566078 Compare July 6, 2024 13:43
@fmaste fmaste marked this pull request as ready for review July 11, 2024 16:13
@fmaste fmaste requested review from a team as code owners July 11, 2024 16:13
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @fmaste ! Thank you so much.

@mgmeier mgmeier added this pull request to the merge queue Jul 12, 2024
Merged via the queue into master with commit 5e787e8 Jul 12, 2024
23 checks passed
@mgmeier mgmeier deleted the bench-profiles branch July 12, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants