wb | enable cardano-profile #8407
Annotations
13 warnings
The following actions uses node12 which is deprecated and will be forced to run on node16: rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Set up HLint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Set up HLint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Set up HLint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Run HLint:
bench/cardano-profile/src/Cardano/Benchmarking/Profile/NodeSpecs.hs#L124
Suggestion in nodeSpecs' in module Cardano.Benchmarking.Profile.NodeSpecs: Use tuple-section ▫︎ Found: "\\ i' -> (i', BFT, 0, True)" ▫︎ Perhaps: "(, BFT, 0, True)" ▫︎ Note: may require `{-# LANGUAGE TupleSections #-}` adding to the top of the file
|
Run HLint:
bench/cardano-profile/src/Cardano/Benchmarking/Profile/NodeSpecs.hs#L152
Suggestion in nodeSpecs' in module Cardano.Benchmarking.Profile.NodeSpecs: Use tuple-section ▫︎ Found: "\\ i' -> (i', Proxy, 0, True)" ▫︎ Perhaps: "(, Proxy, 0, True)" ▫︎ Note: may require `{-# LANGUAGE TupleSections #-}` adding to the top of the file
|
Run HLint:
bench/cardano-profile/src/Cardano/Benchmarking/Profile/NodeSpecs.hs#L165
Suggestion in nodeSpecs' in module Cardano.Benchmarking.Profile.NodeSpecs: Use tuple-section ▫︎ Found: "\\ i' -> (i', ChaindbServer, 0, True)" ▫︎ Perhaps: "(, ChaindbServer, 0, True)" ▫︎ Note: may require `{-# LANGUAGE TupleSections #-}` adding to the top of the file
|
Run HLint:
bench/cardano-profile/src/Cardano/Benchmarking/Profile/NodeSpecs.hs#L178
Suggestion in nodeSpecs' in module Cardano.Benchmarking.Profile.NodeSpecs: Use tuple-section ▫︎ Found: "\\ i' -> (i', Explorer, 0, False)" ▫︎ Perhaps: "(, Explorer, 0, False)" ▫︎ Note: may require `{-# LANGUAGE TupleSections #-}` adding to the top of the file
|
Run HLint:
bench/cardano-profile/src/Cardano/Benchmarking/Profile/Builtin/Empty.hs#L154
Suggestion in profilesNoEraEmpty in module Cardano.Benchmarking.Profile.Builtin.Empty: Use : ▫︎ Found: "[ciTestHydra\n & P.name \"ci-test-hydra\"\n . V.plutusLoop . P.traceForwardingOn . P.newTracing . P.p2pOn]\n ++\n let\n trace\n = P.empty\n & V.datasetEmpty\n . genesis\n . P.torus\n . V.hosts 6 . P.loopback . P.tracerWithresources . V.clusterDefault\n bench = trace & traceBenchDuration\n full = trace & traceFullDuration\n in\n [bench\n & P.name \"trace-bench\"\n . V.valueLocal . P.traceForwardingOn . P.newTracing . P.p2pOff,\n bench\n & P.name \"trace-bench-rtview\"\n . V.valueLocal\n . P.traceForwardingOn . P.newTracing . P.p2pOff . P.tracerRtview,\n bench\n & P.name \"trace-bench-oldtracing\"\n . V.valueLocal . P.traceForwardingOn . P.oldTracing . P.p2pOff,\n bench\n & P.name \"trace-bench-notracer\"\n . V.valueLocal . P.traceForwardingOff . P.newTracing . P.p2pOff,\n full\n & P.name \"trace-full\"\n . V.valueLocal . P.traceForwardingOn . P.newTracing . P.p2pOff,\n full\n & P.name \"trace-full-rtview\"\n . V.valueLocal\n . P.traceForwardingOn . P.newTracing . P.p2pOff . P.tracerRtview]\n ++\n let\n noCliStop\n = P.empty\n & defaultDuration\n . P.uniCircle\n . V.hosts 6\n . P.loopback\n . P.utxo 0 . P.delegators 6 . P.dreps 0 . V.clusterDefault\n value = noCliStop & V.genesisVariant300\n plutus = noCliStop & V.genesisVariantPreVoltaire\n loop = V.plutusLoop\n ecdsa = V.plutusSaturation . V.plutusTypeECDSA\n schnorr = V.plutusSaturation . V.plutusTypeSchnorr\n in\n [value\n & P.name \"default\"\n . V.valueCloud\n . P.traceForwardingOn\n . P.newTracing . P.p2pOff . P.analysisUnitary,\n value\n & P.name \"default-p2p\"\n . V.valueCloud\n . P.traceForwardingOn . P.newTracing . P.p2pOn . P.analysisUnitary,\n value\n & P.name \"oldtracing\"\n . V.valueCloud\n . P.traceForwardingOn\n . P.oldTracing . P.p2pOff . P.analysisUnitary,\n plutus\n & P.name \"plutus\"\n . loop . P.traceForwardingOn . P.newTracing . P.p2pOff,\n plutus\n & P.name \"plutus-secp-ecdsa\"\n . ecdsa . P.traceForwardingOn . P.newTracing . P.p2pOff,\n plutus\n & P.name \"plutus-secp-schnorr\"\n . schnorr . P.traceForwardingOn . P.newTracing . P.p2pOff]\n ++\n let\n ep\n = P.empty\n & V.datasetEmpty\n . genesis\n . epochTransitionDuration\n . P.uniCircle . V.hosts 2 . P.loopback . V.clusterDefault\n in\n [ep\n & P.name \"epoch-transition\"\n . V.valueLocal . P.traceForwardingOn . P.newTracing . P.p2pOff]" ▫︎ Perhaps: "(ciTestHydra\n & P.name \"ci-test-hydra\"\n . V.plutusLoop . P.traceForwardingOn . P.newTracing . P.p2pOn)\n : let\n trace\n = P.empty\n & V.datasetEmpty\n . genesis\n . P.torus\n . V.hosts 6 . P.loopback . P.tracerWithresources . V.clusterDefault\n bench = trace & traceBenchDuration\n full = trace & traceFullDuration\n in\n [bench\n & P.name \"trace-bench\"\n . V.valueLocal . P.traceForwardingOn . P.newTracing . P.p2pOff,\n bench\n & P.name \"trace-bench-rtview\"\n . V.valueLocal\n . P.traceForwardingOn . P.newTracing . P.p2pOff . P.tracerRtview,\n bench\n & P.name \"trace-bench-oldtracing\"\n . V.valueLocal . P.traceForwardingOn . P.oldTracing . P.p2pOff,\n bench\n & P.name \"trace-bench-notracer\"\n . V.valueLocal . P.traceForwardingOff . P.newTracing . P.p2pOff,\n full\n & P.name \"trace-full\"\n . V.valueLocal . P.traceForwardingOn . P.newTracing . P.p2pOff,\n full\n & P.name \"trace-full-rtview\"\n . V.valueLocal\n . P.traceForwardingOn . P.newTracing . P.p2pOff . P.tracerRtview]\n ++\n let\n noCliStop\n = P.empty\n & defaultDuration\n . P.uniCircle\n . V.hosts 6\n . P.loopback\n . P.utxo 0 . P.delegators 6 . P.dreps 0 . V.clusterDefault\n value = noCliStop & V.genesisVariant300\n plutus = noCliStop & V.genesisVariantPreVoltaire\n loop = V.plutusLoop\n ecdsa = V.plutusSaturation . V.plutusTypeECDSA\n schnorr = V.plutusSaturation . V.plutusTypeSchnorr\n in\n [value\n & P.name \"default\"\n . V.valueCloud\n . P.traceForwardingOn\n . P.newTracing . P.p2pOff . P.analysisUnitary,\n value\n & P.name \"default-p2p\"\n . V.valueCloud\n . P.traceForwardingOn . P.newTracing . P.p2pOn . P.analysisUnitary,\n value\n & P.name \"oldtracing\"\n . V.valu
|
Run HLint:
bench/cardano-topology/app/cardano-topology.hs#L82
Suggestion in getOpts in module Main: Move brackets to avoid $ ▫︎ Found: "(hsubparser\n $ command\n \"make\"\n (info\n (Make <$> cliParserMake)\n (fullDesc\n <> header \"make\" <> progDesc \"Create a cluster topology\"))\n <>\n command\n \"projection-for\"\n (info\n (ProjectionFor\n <$>\n strOption\n (long \"topology-input\"\n <> help \"Topology file\" <> metavar \"INPUTFILE\")\n <*> cliParserProjection)\n (fullDesc\n <>\n header \"projection-for\"\n <> progDesc \"Create an individual topology\")))\n <**> helper" ▫︎ Perhaps: "hsubparser\n (command\n \"make\"\n (info\n (Make <$> cliParserMake)\n (fullDesc\n <> header \"make\" <> progDesc \"Create a cluster topology\"))\n <>\n command\n \"projection-for\"\n (info\n (ProjectionFor\n <$>\n strOption\n (long \"topology-input\"\n <> help \"Topology file\" <> metavar \"INPUTFILE\")\n <*> cliParserProjection)\n (fullDesc\n <>\n header \"projection-for\"\n <> progDesc \"Create an individual topology\")))\n <**> helper"
|
Run HLint:
bench/cardano-topology/src/Cardano/Benchmarking/Topology/Projection.hs#L56
Suggestion in NetworkTopology in module Cardano.Benchmarking.Topology.Projection: Use newtype instead of data ▫︎ Found: "data NetworkTopology\n = RealNodeTopology ![RemoteAddress]\n deriving (Eq, Show)" ▫︎ Perhaps: "newtype NetworkTopology\n = RealNodeTopology [RemoteAddress]\n deriving (Eq, Show)"
|
Run HLint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Loading