Skip to content

CDDL improvements #4996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CDDL improvements #4996

wants to merge 1 commit into from

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Apr 16, 2025

Description

This PR uses a newer version of cuddle, which makes it possible to manually specify the order in which Huddle definitions appear. Also some of the comments about fields are now attached to the fields themselves, instead of being printed out in a long comment in front of the definition.

The pretty printer has also been improved a bit, but there are still many places where the formatting is a bit off. The pretty printer could still be improved a lot, but at least the current version is a bit closer to what I'd like it to be once it's finished.

close #4974

blocked on IntersectMBO/cardano-haskell-packages#1072

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@Soupstraw Soupstraw force-pushed the jj/cddl-ordering branch 14 times, most recently from daf12fe to f070721 Compare April 22, 2025 11:08
@Soupstraw Soupstraw marked this pull request as ready for review April 22, 2025 11:16
@Soupstraw Soupstraw requested a review from a team as a code owner April 22, 2025 11:16
@Soupstraw Soupstraw force-pushed the jj/cddl-ordering branch 6 times, most recently from 75adbcb to 10739f9 Compare April 22, 2025 15:27
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first pass on this - not easy to review, particularly the final cddl files!
Will take another look tomorrow

@Soupstraw Soupstraw force-pushed the jj/cddl-ordering branch 3 times, most recently from 5aee68a to 2eccb20 Compare April 25, 2025 14:37
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Love the new formatting, comment placing and ability to specify the order of definitions.

Nice work @Soupstraw

@Soupstraw Soupstraw force-pushed the jj/cddl-ordering branch from 799676c to e9e979b Compare May 8, 2025 10:54
@Soupstraw Soupstraw force-pushed the jj/cddl-ordering branch 5 times, most recently from 92ae540 to 348d588 Compare May 15, 2025 16:30
@Soupstraw Soupstraw force-pushed the jj/cddl-ordering branch 5 times, most recently from 36c4f1f to 5c7ec00 Compare May 16, 2025 16:40
@Soupstraw Soupstraw enabled auto-merge (rebase) May 16, 2025 16:40
@Soupstraw Soupstraw requested a review from lehins May 19, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from using mutable CDDL definitions
3 participants