Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ApplyBlock interface #4889

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Feb 12, 2025

Description

This PR:

  • adds functionality for producing the result of STS that does not change the resulting type because of events option.
  • Removes ability to customize assertion policy, since that is only needed for tests
  • removes bunch of redundant superclass constraints from ApplyBlock
  • It also disables validation for applyTICK, since TICK can't fail anyways.

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins force-pushed the lehins/sts-result-non-dependant-on-events-option branch 2 times, most recently from e4b7efd to ddce44a Compare February 14, 2025 22:22
@lehins lehins force-pushed the lehins/sts-result-non-dependant-on-events-option branch from ebae159 to a977be7 Compare February 21, 2025 02:58
@lehins lehins requested a review from jasagredo February 21, 2025 02:59
@lehins lehins marked this pull request as ready for review February 21, 2025 03:02
@lehins lehins requested a review from a team as a code owner February 21, 2025 03:02
@lehins lehins requested a review from neilmayhew February 21, 2025 03:03
@lehins lehins changed the title Introduce applyBlockOptsEither Change ApplyBlock interface Feb 21, 2025
Copy link
Contributor

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@lehins lehins force-pushed the lehins/sts-result-non-dependant-on-events-option branch from a977be7 to 3c97d15 Compare February 21, 2025 22:51
@lehins lehins enabled auto-merge February 21, 2025 22:51
@lehins lehins merged commit cc7c6af into master Feb 22, 2025
153 of 154 checks passed
@lehins lehins deleted the lehins/sts-result-non-dependant-on-events-option branch February 22, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants