Upgrade to PostgreSQL 17 #1936
Merged
Upgrade to PostgreSQL 17 #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillespie
force-pushed
the
feature/postgres-17
branch
from
7d12cec to
98ccdbb
Compare
sgillespie
force-pushed
the
feature/postgres-17
branch
from
f978d05 to
3f29a80
Compare
15 tasks
sgillespie
force-pushed
the
feature/postgres-17
branch
from
3f29a80 to
641c8dd
Compare
Cmdv
reviewed
Jan 28, 2025
| @@ -24,6 +24,10 @@ | |||
| url = "github:IntersectMBO/cardano-haskell-packages?ref=repo"; | |||
| flake = false; | |||
| }; | |||
| # Note[PostgreSQL 17]: This is a workaround to get postgresql_17 from nixpkgs. It's | |||
There was a problem hiding this comment.
we could maybe create an issue and link it here so we can track it being done
There was a problem hiding this comment.
Good point, we had the original discussion here: #1875
There was a problem hiding this comment.
sweet if that will jog memories then ✅
There was a problem hiding this comment.
sweet if that will jog memories then ✅
Do you think we should create another issue, just repurpose #1875 above?
There was a problem hiding this comment.
totally up to you, new issue always helps with "throughput"
There was a problem hiding this comment.
OK, I just renamed it. I think a whole new ticket would make it a blatant duplicate
Cmdv
approved these changes
Jan 30, 2025
kderme
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for PostgreSQL 17. Note that for static building, we still need pg16 for the time being
Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.