Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index state #776

Closed
wants to merge 1 commit into from
Closed

Update index state #776

wants to merge 1 commit into from

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented May 26, 2024

Changelog

- description: |
    Update index state
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

The additional constraint in cabal.project is explained in a comment below.

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the lock file.

cabal.project Outdated
Comment on lines 41 to 42
constraints:
io-classes-mtl < 0.1.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment to explain why this is necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't include it you get this error:

src/Control/Monad/Class/MonadSTM/Trans.hs:116:5: error: [GHC-54721]
    ‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
    |
116 |     writeTMVar     = ContTSTM .: writeTMVar
    |     ^^^^^^^^^^

src/Control/Monad/Class/MonadSTM/Trans.hs:194:5: error: [GHC-54721]
    ‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
    |
194 |     writeTMVar     = lift .: writeTMVar
    |     ^^^^^^^^^^

src/Control/Monad/Class/MonadSTM/Trans.hs:272:5: error: [GHC-54721]
    ‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
    |
272 |     writeTMVar     = lift .: writeTMVar
    |     ^^^^^^^^^^

src/Control/Monad/Class/MonadSTM/Trans.hs:350:5: error: [GHC-54721]
    ‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
    |
350 |     writeTMVar     = lift .: writeTMVar
    |     ^^^^^^^^^^

src/Control/Monad/Class/MonadSTM/Trans.hs:428:5: error: [GHC-54721]
    ‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
    |
428 |     writeTMVar     = lift .: writeTMVar
    |     ^^^^^^^^^^

src/Control/Monad/Class/MonadSTM/Trans.hs:506:5: error: [GHC-54721]
    ‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
    |
506 |     writeTMVar     = lift .: writeTMVar
    |     ^^^^^^^^^^

src/Control/Monad/Class/MonadSTM/Trans.hs:584:5: error: [GHC-54721]
    ‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
    |
584 |     writeTMVar     = lift .: writeTMVar
    |     ^^^^^^^^^^

src/Control/Monad/Class/MonadSTM/Trans.hs:662:5: error: [GHC-54721]
    ‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
    |
662 |     writeTMVar     = lift .: writeTMVar
    |     ^^^^^^^^^^

This is just changes in the definition of type classes in our dependencies that break other dependencies. When all our other dependencies update accordingly we can remove this constraint.

@newhoggy newhoggy requested a review from smelc May 28, 2024 11:25
Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch from 8f330a7 to 07f31da Compare May 30, 2024 22:05
@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch from 07f31da to f95181f Compare May 30, 2024 22:06
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lock files need to be updated

@carbolymer
Copy link
Contributor

Closing as it's not needed anymore.

@carbolymer carbolymer closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants