-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index state #776
Update index state #776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to update the lock file.
cabal.project
Outdated
constraints: | ||
io-classes-mtl < 0.1.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment to explain why this is necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't include it you get this error:
src/Control/Monad/Class/MonadSTM/Trans.hs:116:5: error: [GHC-54721]
‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
|
116 | writeTMVar = ContTSTM .: writeTMVar
| ^^^^^^^^^^
src/Control/Monad/Class/MonadSTM/Trans.hs:194:5: error: [GHC-54721]
‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
|
194 | writeTMVar = lift .: writeTMVar
| ^^^^^^^^^^
src/Control/Monad/Class/MonadSTM/Trans.hs:272:5: error: [GHC-54721]
‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
|
272 | writeTMVar = lift .: writeTMVar
| ^^^^^^^^^^
src/Control/Monad/Class/MonadSTM/Trans.hs:350:5: error: [GHC-54721]
‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
|
350 | writeTMVar = lift .: writeTMVar
| ^^^^^^^^^^
src/Control/Monad/Class/MonadSTM/Trans.hs:428:5: error: [GHC-54721]
‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
|
428 | writeTMVar = lift .: writeTMVar
| ^^^^^^^^^^
src/Control/Monad/Class/MonadSTM/Trans.hs:506:5: error: [GHC-54721]
‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
|
506 | writeTMVar = lift .: writeTMVar
| ^^^^^^^^^^
src/Control/Monad/Class/MonadSTM/Trans.hs:584:5: error: [GHC-54721]
‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
|
584 | writeTMVar = lift .: writeTMVar
| ^^^^^^^^^^
src/Control/Monad/Class/MonadSTM/Trans.hs:662:5: error: [GHC-54721]
‘writeTMVar’ is not a (visible) method of class ‘MonadSTM’
|
662 | writeTMVar = lift .: writeTMVar
| ^^^^^^^^^^
This is just changes in the definition of type classes in our dependencies that break other dependencies. When all our other dependencies update accordingly we can remove this constraint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
8f330a7
to
07f31da
Compare
07f31da
to
f95181f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lock files need to be updated
Closing as it's not needed anymore. |
Changelog
The additional constraint in
cabal.project
is explained in a comment below.Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist