-
Notifications
You must be signed in to change notification settings - Fork 19
Simplify query format flag #1191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cioWriteTextOutput | ||
:: Maybe (File content Out) | ||
-> Text | ||
-> CIO e () | ||
cioWriteTextOutput mOutput t = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cioWriteTextOutput | |
:: Maybe (File content Out) | |
-> Text | |
-> CIO e () | |
cioWriteTextOutput mOutput t = | |
writeTextOutput | |
:: Maybe (File content Out) | |
-> Text | |
-> CIO e () | |
writeTextOutput mOutput t = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed it to maybeWriteTextOutput
because writeTextOutput
is already exported by cardano-api
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe
in the name is misleading IMHO, because it'll always write output, but just to a different place. Why not writeOutput
or something simpler? Ideally, we should create a type class for various output types (I saw Text
, lazy and strict ByteString
s). But that's out of scope of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to writeOutput
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still maybeWriteTextOutput
in the PR 😅
4c998f2
to
4cbe194
Compare
4cbe194
to
9af8d99
Compare
9af8d99
to
199c2fc
Compare
199c2fc
to
616fc78
Compare
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist