Skip to content

Refactor: rename module structure accordingly to ADR-009 #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    Refactor: change module structure according to [ADR-009](https://github.com/input-output-hk/cardano-node-wiki/wiki/ADR-009-cardano-api-exports-convention)
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

TODO

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer self-assigned this May 14, 2025
@carbolymer carbolymer force-pushed the mgalazyn/refactor/rename-modules branch 3 times, most recently from 290fd3d to 6bef0e2 Compare May 14, 2025 13:08
@carbolymer carbolymer force-pushed the mgalazyn/refactor/rename-modules branch from 6bef0e2 to f025e72 Compare May 21, 2025 13:11
@carbolymer carbolymer force-pushed the mgalazyn/refactor/rename-modules branch from f025e72 to 652fa8f Compare May 21, 2025 14:53
, ("HasTypeProxy", "Internal.HasTypeProxy")

, ("Hash", "Hash")
]

Check failure

Code scanning / HLint

Parse error: on input `]' Error

refactor.hs:143:3: Error: Parse error: on input ]'    Found:       , ("Hash", "Hash")   >   ]            -- TODO remove Cardano.Api.Shelley, and make sure that everything is exported from Cardano.Api`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant