-
Notifications
You must be signed in to change notification settings - Fork 23
Add genBlockHeader and related functions to Test.Gen.Cardano.Api.Typed
#834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
locallycompact
wants to merge
1
commit into
IntersectMBO:master
Choose a base branch
from
locallycompact:lc/genBlockHeader
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add genBlockHeader and related functions to Test.Gen.Cardano.Api.Typed
#834
locallycompact
wants to merge
1
commit into
IntersectMBO:master
from
locallycompact:lc/genBlockHeader
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test.Gen.Cardano.Api.Typed
carbolymer
reviewed
May 5, 2025
Jimbo4350
approved these changes
May 5, 2025
carbolymer
approved these changes
May 7, 2025
dfc0e9b
to
0478dbb
Compare
Is this OK? |
@locallycompact yes, but there are some test failures: https://github.com/IntersectMBO/cardano-api/pull/834/checks?check_run_id=41827008602 |
560e54a
to
a2ec7c0
Compare
I think this is good now. |
carbolymer
reviewed
May 19, 2025
8dd79b2
to
0a577ac
Compare
auto-merge was automatically disabled
May 23, 2025 11:27
Head branch was pushed to by a user without write access
0a577ac
to
08d802b
Compare
Signed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
I have ported these directly from hydra. Let me know if you would change anything. cardano-scaling/hydra#1987
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist