Skip to content

Add genBlockHeader and related functions to Test.Gen.Cardano.Api.Typed #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

locallycompact
Copy link
Contributor

@locallycompact locallycompact commented May 2, 2025

Changelog

- description: |
    Add `genBlockHeader` and related functions to `Test.Gen.Cardano.Api.Typed`.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

I have ported these directly from hydra. Let me know if you would change anything. cardano-scaling/hydra#1987

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@locallycompact locallycompact changed the title Lc/gen block header Add genBlockHeader and related functions to Test.Gen.Cardano.Api.Typed May 2, 2025
@locallycompact
Copy link
Contributor Author

Is this OK?

@carbolymer
Copy link
Contributor

@locallycompact locallycompact force-pushed the lc/genBlockHeader branch 3 times, most recently from 560e54a to a2ec7c0 Compare May 14, 2025 13:20
@locallycompact
Copy link
Contributor Author

I think this is good now.

@locallycompact locallycompact force-pushed the lc/genBlockHeader branch 2 times, most recently from 8dd79b2 to 0a577ac Compare May 19, 2025 08:52
@carbolymer carbolymer enabled auto-merge May 20, 2025 08:10
auto-merge was automatically disabled May 23, 2025 11:27

Head branch was pushed to by a user without write access

@locallycompact
Copy link
Contributor Author

Signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants