Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct pattern for stake deregistration certs in Conway #657

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Oct 21, 2024

Changelog

- description: |
    Use correct stake deregistration certs in Conway
    Require 400,000 deposit when registering keys in `defaultShelleyGenesis`.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This ledger change:

Has triggered this defect:

Because we were using a pattern meant for older eras, for deregistration certificates in Conway.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/fix/correctly-match-on-conway-stake-unreg branch from 16e35b6 to 698a69c Compare October 21, 2024 10:52
@carbolymer carbolymer changed the title Use correct stake deregistration certs in Conway Use correct pattern for stake deregistration certs in Conway Oct 21, 2024
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct fix. The fix definitely did not belong in cardano-cli.

@carbolymer carbolymer added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit c887fa0 Oct 21, 2024
29 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/correctly-match-on-conway-stake-unreg branch October 21, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants