Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set package bounds #301

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

paweljakubas
Copy link
Collaborator

No description provided.

@paweljakubas paweljakubas self-assigned this Feb 20, 2025
Copy link
Contributor

@abailly abailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we set bounds in cabal file we should remove them in cabal.project

@paweljakubas paweljakubas requested a review from abailly February 20, 2025 17:33
@abailly
Copy link
Contributor

abailly commented Feb 21, 2025

Why are the ci/ jobs failing whereas the GHA are succeeding with both GHC versions?

@abailly
Copy link
Contributor

abailly commented Feb 21, 2025

I think this is a similar problem than the one I experienced when I tried to publish cardano-wallet packages to CHaP: There's something problematic with GHC 8.10.7 in Haskell.nix or whatever that prevents building packages which depend on doctest. Perhaps @angerman could confirm?

@angerman
Copy link
Collaborator

@abailly they all failed for cabal-doctest, @paweljakubas seems to have fixed them! 🎉

rm redundant mtl dependency

add bound on with-utf8

rm dependancy in cabal.project

change ghc used

revisit bounds
add ghc 9.10 to workflows checks
@paweljakubas paweljakubas force-pushed the paweljakubas/define-package-bounds branch from 5dd78fa to 41e959c Compare February 21, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants