Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add record of all memberships #5

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Add record of all memberships #5

merged 1 commit into from
Sep 19, 2024

Conversation

andy-isoc
Copy link
Contributor

@andy-isoc andy-isoc commented Sep 19, 2024

Not sure if there are other edge cases we want to catch now? We should be able to run some analysis on the imported data in dev after deploying this change to see if any others do exist in the data.

@andy-isoc andy-isoc marked this pull request as ready for review September 19, 2024 08:36
Copy link

@madofo madofo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. No other edge cases leap out at me, but as you say some analysis on dev after applying this change might shed further light.

@andy-isoc andy-isoc force-pushed the add-membership-history branch from 7308d21 to ab88270 Compare September 19, 2024 10:43
@andy-isoc andy-isoc merged commit ab88270 into main Sep 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants