-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exception handler for proxy server #2901
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvhan028
reviewed
Dec 23, 2024
We'd better log each request, include add, remove, v1/chat/completions, v1/compeltions @app.post('/nodes/add', dependencies=[Depends(check_api_key)])
def add_node(node: Node, raw_request: Request = None):
"""Add a node to the manager.
- url (str): A http url. Can be the url generated by
`lmdeploy serve api_server`.
- status (Dict): The description of the node. An example:
{models: ['internlm-chat-7b], speed: 1}. The speed here can be
RPM or other metric. All the values of nodes should be the same metric.
"""
try:
logger.info(f'try to add node {node.url}, {node.status}')
res = node_manager.add(node.url, node.status)
if res is not None:
logger.error(f'add node {node.url} failed, {res}'
return res
logger.info(f'add node {node.url} successfully')
return f'add node {node.url} successfully'
except: # noqa
return f'Failed to add, node {node.url} please check the input url.' |
lvhan028
reviewed
Dec 24, 2024
lvhan028
reviewed
Dec 24, 2024
lvhan028
reviewed
Dec 24, 2024
lvhan028
approved these changes
Dec 25, 2024
RunningLeon
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lvhan028
pushed a commit
that referenced
this pull request
Dec 27, 2024
* Fix exception handle for proxy server * fix * fix exception handler * Add more logs * fix typo * logger.warn -> logger.warning * logger info * add error log for exception * better log * rename varaibles & reset timeout to * update docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.