Support Qwen2-MoE models #2723
Merged
Support Qwen2-MoE models #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lzhangzz
commented
Nov 7, 2024
lzhangzz
commented
- Qwen1.5-MoE-A2.7B-Chat
- Qwen1.5-MoE-A2.7B-Chat-GPTQ-Int4
- Qwen2-57B-A14B-Instruct
- Qwen2-57B-A14B-Instruct-GPTQ-Int4
|
@zhulinJulia24 may update the TCs |
lvhan028
reviewed
Nov 8, 2024
| @@ -50,6 +50,8 @@ class ModelConfig: | |||
| expert_num: int = 0 | |||
| expert_inter_size: int = 0 | |||
| experts_per_token: int = 0 | |||
| moe_shared_gate: int = False | |||
lvhan028
reviewed
Nov 8, 2024
| @@ -301,6 +301,8 @@ LlamaTritonModel<T>::LlamaTritonModel(size_t tensor_para_size, | |||
| moe_param_.expert_num = model_reader["expert_num"].as<int>(0); | |||
| moe_param_.experts_per_token = model_reader["experts_per_token"].as<int>(0); | |||
| moe_param_.inter_size = model_reader["expert_inter_size"].as<int>(0); | |||
| moe_param_.shared_gate = model_reader["moe_shared_gate"].as<int>(0); | |||
lvhan028
reviewed
Nov 8, 2024
| info['experts_per_token'] = cfg['num_experts_per_tok'] | ||
| info['inter_size'] = cfg['shared_expert_intermediate_size'] | ||
| info['moe_shared_gate'] = True | ||
| info['moe_norm_topk_prob'] = cfg['norm_topk_prob'] |
There was a problem hiding this comment.
moe_norm_topk_prob is not defined in class ModelConfig
lvhan028
reviewed
Nov 8, 2024
| CUDA_R_32F, | ||
| weight.output_dims, | ||
| CUDA_R_32F, | ||
| CUBLAS_GEMM_DEFAULT_TENSOR_OP); | ||
| } | ||
|
|
||
| template<class T> | ||
| void MoeFfnLayer<T>::forward(T* inout, int tokens, int layer_id, const MoeFfnWeight<T>& moe) | ||
| void MoeFfnLayer<T>::forward(T* output, const T* input, int tokens, int layer_id, const MoeFfnWeight<T>& moe) |
There was a problem hiding this comment.
the added output seems unused.
lvhan028
approved these changes
Nov 12, 2024
irexyc
approved these changes
Nov 13, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.