-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support molmo in turbomind #2716
Conversation
It seems doesn't support text only input like
|
lmdeploy/vl/templates.py
Outdated
await asyncio.gather(*[ | ||
asyncio.get_event_loop().run_in_executor(None, _inner_call, i, | ||
messages, out_messages) | ||
for i in range(len(messages)) | ||
]) | ||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When adding elements to out_messages, parameter i
should be considered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And after fixing the order, I find the position of Assistant
seems not right. I decode the input token and the result is
" User: Describe the two images in detail. Assistant:Assistant: xxx...User: What are the similarities and differences between these two images. "
(use the multi-round example here)
If the input only has one user content and decode the input ids, the result is
" User: Describe the two images in detail. Assistant:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Fixed |
model: allenai/Molmo-7B-D-0924