support turbomind head_dim 64 #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvhan028
reviewed
Nov 6, 2024
lvhan028
reviewed
Nov 6, 2024
lvhan028
reviewed
Nov 6, 2024
lvhan028
reviewed
Nov 6, 2024
| @@ -241,10 +241,10 @@ void invokeProcessKV_v2(char** blocks, | |||
| int block = WARPS * WARP_SIZE; | |||
| dim3 grid((max_q_len + CTA_S - 1) / CTA_S, head_num, batch_size); | |||
|
|
|||
| auto invoke = [&](auto tkv) { | |||
| auto invoke = [&](auto tkv, const auto dim) { | |||
There was a problem hiding this comment.
@lzhangzz what does tkv mean?
There was a problem hiding this comment.
I think it means target kv datatype
lvhan028
reviewed
Nov 6, 2024
|
@zhulinJulia24 may add the following models into tm test set
|
lvhan028
approved these changes
Nov 6, 2024
|
done
done |
lzhangzz
approved these changes
Nov 6, 2024
AllentDan
pushed a commit
to AllentDan/lmdeploy
that referenced
this pull request
Nov 13, 2024
* support head_dim 64 * fix unit-test * fix wrong dispatch * fix comments * fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
support models with head_dim = 64 like
InternVL/InternVL2-1B/andQwen/Qwen1.5-0.5B-Chat/