Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add fisheye model support #1

Merged
merged 5 commits into from
Dec 17, 2018

Conversation

PerrineAguiar
Copy link

Adds support for fisheye model in image_geometry.

@PerrineAguiar PerrineAguiar requested a review from meyerj December 7, 2018 09:34
Copy link

@meyerj meyerj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and released as a Debian to override upstream ros-kinetic-image-geometry. The release branches have been pushed directly to this repo.

In order to update the Debian:

  1. Update the upstream branch to whatever branch you want to release.
  2. Run git-bloom-release kinetic.
  3. Checkout branch debian/ros-kinetic-image-geometry_x.y.z-i_xenial.
  4. Run dpkg-buildpackage -us -uc -b.
  5. Push all branches and tags.

@PerrineAguiar
Copy link
Author

@meyerj Nit addressed.
And I added support for the opencv fisheye model.

@meyerj
Copy link

meyerj commented Jun 16, 2022

The EQUIDISTANT model that is equivalent to our FISHEYE_CV has been added in ros-perception#358.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants