Ignore if module folder can't be deleted

Intermesh · Jan 27, 2025 · cd70d0c · cd70d0c
1 parent 41f1c3e
commit cd70d0c
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/www/go/modules/community/multi_instance/model/Instance.php b/www/go/modules/community/multi_instance/model/Instance.php
@@ -834,13 +834,17 @@ protected static function internalDelete(Query $query): bool
 
 				$instance->mysqldump();
 
-				$modPackageFolder = $instance->getModulePackageFolder();
-				if($modPackageFolder->exists()) {
-					$dest = $instance->getDataFolder()->getFolder($instance->getStudioPackage() . '_MODULE_PACKAGE');
-					if ($dest->exists()) {
-						$dest = new Folder($dest->getPath() . '-' . uniqid());
+				try {
+					$modPackageFolder = $instance->getModulePackageFolder();
+					if ($modPackageFolder->exists()) {
+						$dest = $instance->getDataFolder()->getFolder($instance->getStudioPackage() . '_MODULE_PACKAGE');
+						if ($dest->exists()) {
+							$dest = new Folder($dest->getPath() . '-' . uniqid());
+						}
+						$instance->getModulePackageFolder()->move($dest);
 					}
-					$instance->getModulePackageFolder()->move($dest);
+				} catch(\Throwable $e) {
+					ErrorHandler::logException($e, "Error while deleting module folder for instance ". $instance->hostname);
 				}
 
 				$instance->getConfigFile()->getFolder()->delete();