Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lispusers/DOCUMENT cleaned up and working with current Tedit #2023

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

rmkaplan
Copy link
Contributor

@rmkaplan rmkaplan commented Feb 7, 2025

The utility of this depends on how careful and thoughtful were the comments in the target source file, but it could be a start for editing up something useful.

I replaced ARGLIST with SMARTARGLIST, and I also made it skip over various formats of edit dates (although I didn't pick out a comment that may be inside an editdate).

I simplified the code quite a bit, eliminating most of the TEDIT.INSERTS by straightforward printout commands. This revealed a missing functionality in Tedit, that there is currently no way to specify the paragraph looks to be used when you print at the end-of-file. TEDIT-PARALOOKS only operates on existing paragraphs. TBD.

@pamoroso pamoroso linked an issue Feb 7, 2025 that may be closed by this pull request
Copy link
Contributor

@pamoroso pamoroso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the patch with both Stringscope and DOCUMENT itself and everything seems to be working fine.

@pamoroso
Copy link
Contributor

pamoroso commented Feb 9, 2025

Is DOCUMENT supposed to work with Common Lisp and CLOS? When I evaluate (Document.Create 'NEW-CLOS-BROWSER) to process medley/clos/NEW-CLOS-BROWSER I get an error like:

TYPE-MISMATCH
In CDR:
#<Compiled Function CLOS-BROWSER:BROWSE-CLASS/131.4464>

@rmkaplan
Copy link
Contributor Author

rmkaplan commented Feb 9, 2025 via email

@pamoroso
Copy link
Contributor

pamoroso commented Feb 9, 2025

You're right, I had forgotten NEW-CLOS-BROWSER is not a managed file. DOCUMENT does work with managed Common Lisp code, for example INSPHEX.

@rmkaplan rmkaplan merged commit ae52a44 into master Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Args not available error when running DOCUMENT
2 participants