Restore fogColor during load #2731
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for looking into issues. Should be good to go once I get around to testing this |
|
For what its worth, I tested the master for this bug (fog turning black), and could reproduce it with 100% certainty by entering a house in foggy weather, saving, then loading the save and exiting. With this branch the bug did not occur despite several tests. Then I did general play for 90 minutes and no problems occurred. I did testing with Win10, in the Unity editor, if that matters. |
|
Thank you for testing. This is small enough that I'm not too worried about mod compatibility, I'll just do a basic code review next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue described in #2730