Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for intended precedence of building overrides when RMB block overrides also present #2714

Merged
merged 4 commits into from
Feb 5, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refined method summary
ajrb committed Dec 23, 2024
commit 1c85e15c8ac10e4481e64f24023bfdfbab1e77de
Original file line number Diff line number Diff line change
@@ -376,6 +376,7 @@ public static bool GetDFBlockReplacementData(int block, string blockName, out DF
}
dfBlock.Index = block;

// For RMB blocks, check for individual building overrides and replace those records.
if (blockName.EndsWith(".RMB"))
ReplaceRmbBlockBuildingData(blockName, block, ref dfBlock);

@@ -390,7 +391,7 @@ public static bool GetDFBlockReplacementData(int block, string blockName, out DF
}

/// <summary>
/// Replace overridden RMB block data with any record specific building data.
/// Replaces overridden RMB block data records with specific building data, if found.
/// </summary>
/// <param name="blockName">Block name</param>
/// <param name="blockIndex">Block index</param>