transaction and request ID clarifications #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robhazan
requested review from
emailcurt,
iantri,
simontrasler,
wittjill and
hillslatt
|
See InteractiveAdvertisingBureau/openrtb#153 for the matching PR in /openrtb |
simontrasler
reviewed
Jan 2, 2024
| @@ -2740,7 +2740,7 @@ This object is associated with a `SupplyChain` object as an array of nodes. Thes | |||
| <tr> | |||
| <td><code>rid</code></td> | |||
| <td>string</td> | |||
| <td>The OpenRTB RequestId of the request as issued by this seller.</td> | |||
| <td>The OpenRTB RequestId of the bid request as issued by the advertising system associated with this Supply Chain Node.</td> | |||
There was a problem hiding this comment.
I recommend putting this through in a separate PR. I have more questions about the need to change this one, since it's possible vendors are relying on the previous definition.
simontrasler
reviewed
Jan 2, 2024
| @@ -855,7 +855,7 @@ This object describes the nature and behavior of the entity that is the source o | |||
| <tr> | |||
| <td><code>tid</code></td> | |||
| <td>string; recommended</td> | |||
| <td>Transaction ID that must be common across all participants in this bid request (e.g., potentially multiple exchanges).</td> | |||
| <td>Transaction ID, generated by the publisher or agent originating an ad request for the end user, that must be common across all participants in this bid request (e.g., all exchanges participating in a header bidding or similar publisher-centric broadcast scenario). It should not be assumed that this ID uniquely identifies 1 biddable impression opportunity, unless that's all that exists on the bid request. Any podded audio/video bid request or multi-impression bid request may reflect multiple concurrent biddable impression opportunities. To uniquely identify those, consider using <a href="https://github.com/InteractiveAdvertisingBureau/openrtb/blob/master/extensions/community_extensions/per-imp-tids.md">per-impression transaction IDs</a>.</td> | |||
There was a problem hiding this comment.
I would consider adding:
This should not be added by middlemen, with better wording. We've found some people don't support the tid on their request and then make one up when they make a request to the next entity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some language to clarify how the SupplyChainNode rid field is intended to be used, as well as clarifying the limitations of the tid field in Source. I do think we should concurrently consider moving per-impression transaction IDs out of community extension into mainline of OpenRTB via Provisional.
I'm creating a matching PR for the /openrtb (3.0) repo.