Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump modules to 1.5.8 #413

Conversation

EdgardoRodriguezSolano
Copy link

@EdgardoRodriguezSolano EdgardoRodriguezSolano commented Aug 17, 2023

Bump modules to 1.5.8
Tests should stop failing
It closes #402

@EdgardoRodriguezSolano
Copy link
Author

Hi @marco-prontera Bumping the module versions to 1.5.8 allows me to yarn test successfully locally. Any chance you can try this on your end. I saw your MR and I'm wondering if I'm missing something. Not sure if they're strictly related as the issue was opened way before the latest release.

@marco-prontera
Copy link
Contributor

Hi @marco-prontera Bumping the module versions to 1.5.8 allows me to yarn test successfully locally. Any chance you can try this on your end. I saw your MR and I'm wondering if I'm missing something. Not sure if they're strictly related as the issue was opened way before the latest release.

Hi @EdgardoRodriguezSolano these are different things but in the PR I opened I fixed also this "bug" in 1.5.8. This problem was that the deploy from 1.5.7 isn't done with regular deploy scripts always used with that library, the deploy scripts update every version of every package.json file to the new deployed version automatically and these things will no happens. On the other hand the PR I opened solve an issue related to the execution of tests, used during the development phase and GitHub pipelines because currently they don't run all as we need (only some tests runs).

I hope they will review and merge the PR I listed in the issue #411 soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests doesn't run correctly [URGENT]
2 participants