Add sandbox attribute to omid_v1_present iframe #31
Conversation
|
Thanks, Brett. What we will do is merge this into the upstream repo and then it'll end up here after the next release. I'll let you know once it is merged and then we can close this PR. If you want to contribute more to the upstream repo you can join the commit group (email [email protected] for more info). |
|
Sounds good @nlehrer, thanks for clarifying. Is there a release schedule I can follow? |
|
There is a release about once every two weeks. We haven't published an official release schedule, but I can ask about that possibility. We're planning to do a release sometime this week. |
|
@nlehrer has then been merged into the upstream repo and should I close this PR? |
| @@ -66,6 +67,7 @@ exports.appendPresenceIframe_ = function(globalObject) { | |||
| iframe.id = exports.OMID_PRESENT_FRAME_NAME; | |||
| iframe.name = exports.OMID_PRESENT_FRAME_NAME; | |||
| iframe.style.display = 'none'; | |||
| iframe.sandbox = undefined; | |||
There was a problem hiding this comment.
FYI setting this to undefined causes the browser to complain; setting it to empty string seems to be the right way to set it to just "sandbox".
There was a problem hiding this comment.
Oh interesting... Thanks for the follow up. Want me to make this change, or will you do it in the other repo?
There was a problem hiding this comment.
I did it in the other repo PR. Thanks.
|
It's going to be merged today or tomorrow (will keep you updated). I'm closing this one meanwhile. Thanks! |
Resolves #30