-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves Issue 126 #127
base: main
Are you sure you want to change the base?
Resolves Issue 126 #127
Conversation
</tr> | ||
<tr> | ||
<td>NumPubRestrictions</td> | ||
<td>Int(12)</td> | ||
<td>Number of restriction records to follow.<br></br>Value is required even if it is <code>0</code></td> | ||
<td>Number of restriction records to follow.<br>Value is required even if it is <code>0</code></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be removed and replaced with one field of type ArrayOfRanges (replaces NumPubRestrictions, PurposeID, RestrictionType, PubRestrictionEntry)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, @janwinkler please take a look as the new section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HeinzBaumann maybe just clarification on the last line:
"A single or range of Vendor ID(s) who the publisher has designated as restricted under the purpose id."
--> "A list of Vendor ID(s) who the publisher has designated as restricted under the purpose id encoded as bitmask or ranges."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe one thing to highlight to implementers (implementers guide?) is that the output of the JS API for the restrictions field is not exactly the same as what they know from the __tcfapi output for the restrictions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I made this modification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janwinkler if this is now okay from your end, please approve this PR.
This PR addresses several issues found in the EEA Section spec and brings this spec to date with the latest TCF 2.2 specification.