doge-serverless #116
doge-serverless #116
Conversation
…API, sends SNS message with the signal (TA-Lib not included)
…NS message, some code refactoring
…al, GP strategy triggered by SNS working
ghost
assigned 
There was a problem hiding this comment.
Overall, nice work. Only a few comments inline for requested changes.
Thanks for reviewing all my code and improving! much appreciated knowing you went through it all and cleaned it up. Also, I see you needed to use Docker? we should talk about that and how it affects the deployment process.
| return self.get_indicator("SMA") | ||
|
|
||
| def ema50(self, input): | ||
| return self.get_indicator("RSI") |
There was a problem hiding this comment.
@sodogemuchwow this looks like a mistake. can comment out until ema50 and other indicators are available
| def context(self): | ||
| return None # :handwave: not the droid your looking for | ||
| def sns_event(self): | ||
| return self._sns_event # or not the droids we're looking for? |
| ############################################################# | ||
| ####### I don't think we need any of the functions below | ||
| ####### Or at least I don't see how they would be usable in an SNS-triggered architecture | ||
| ############################################################## |
There was a problem hiding this comment.
cool. you can remove them. I copied them in as a reminder to write what's needed for querying the database. maybe better to leave a # todo and refer to this code in core for reference on building the query stuff
|
bringing in all latest updates in master |
GP logic compiled and working, classic strategies invoked by and receive indicators from SNS, signals published to SNS. All tested on AWS (mock endpoints, topics and data).