-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dist tests #147
Fix dist tests #147
Commits on Apr 24, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c44e5b0 - Browse repository at this point
Copy the full SHA c44e5b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e517595 - Browse repository at this point
Copy the full SHA e517595View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ec32f6 - Browse repository at this point
Copy the full SHA 5ec32f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68d7d18 - Browse repository at this point
Copy the full SHA 68d7d18View commit details
Commits on Apr 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 2e53d46 - Browse repository at this point
Copy the full SHA 2e53d46View commit details -
I used the more modern PEP 518 (pyproject.toml) packaging standard rather than setuptools, requirements.txt, etc. directly. Instead of using Cython.Build.cythonize and distuils.Extensions in setup.py, a typical method to create cython extensions, I opted to use the scikit-build package, which handles gluing setup.py with CMake. In particular, some changes to the directory structure, imports and Cython modules themselves needed to be made to work with scikit-build because it uses the cython executable rather than the Cython.Build.cythonize API. This seems a net positive anyway because one can reproduce the build steps manually for debugging purposes with: cython -3 --cplus -I .. -I .. file.pyx Development can be done in the traditional Python way with some adjustments for the underlying CMake build system: python setup.py build_ext --inplace -- -DCMAKE_OPTIONS=... # or export GALOIS_CMAKE_ARGS=-DCMAKE_OPTIONS=... pip install -e . --no-build-isolation The python directory structure was reorganized to ease packaging as well. All Galois Python packages are now under the package galois. The libgalois_shem bindings are in galois.shmem. To avoid conflicts with existing CMake target names, the test applications are under galois._bfs, ... with import aliases galois.bfs, ... respectively.
Configuration menu - View commit details
-
Copy full SHA for cf33042 - Browse repository at this point
Copy the full SHA cf33042View commit details -
Update BFS and PageRank in Cython
Need a better way to initialize shared memory runtime. Using explicit "new" as Default constructors are not being called.
Configuration menu - View commit details
-
Copy full SHA for c5b3d38 - Browse repository at this point
Copy the full SHA c5b3d38View commit details -
pangolin: Use standard CMake build
- Rather than create new symbols like USE_GPU follow the pattern of other libgpu/libdist which uses ENABLE_HETRO_GALOIS (-D__GALOIS_HET_CUDA__=1) to signal GPU configurations. - Namespace MAX_SIZE macro to avoid clobbering MAX_SIZE symbols defined elsewhere. - Depend on libraries to provide their include directories and other configuration rather than obsolete app function. - Move third-party dependencies to distinguished external directory rather than burying them in our own code. - Delete unreferenced and non-building code.
Configuration menu - View commit details
-
Copy full SHA for 748a6f6 - Browse repository at this point
Copy the full SHA 748a6f6View commit details -
pangolin: Prefix include directories
Without prefixes it is difficult to determine where to find the source of includes. Also it makes installation difficult because there there may be filename conflicts among installations (e.g., util.h vs util.h). Add "pangolin/" as a directory prefix to all pangolin includes. I didn't go further to distinguish GPU and CPU versions of pangolin; though that is an obvious next step. The pangolin library relies on include tricks to work so defer further refactoring until the library is more separated from its applications.
Configuration menu - View commit details
-
Copy full SHA for 9efc67c - Browse repository at this point
Copy the full SHA 9efc67cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca27285 - Browse repository at this point
Copy the full SHA ca27285View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2540298 - Browse repository at this point
Copy the full SHA 2540298View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3abf3b - Browse repository at this point
Copy the full SHA a3abf3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 706aebd - Browse repository at this point
Copy the full SHA 706aebdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1581c42 - Browse repository at this point
Copy the full SHA 1581c42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5db158d - Browse repository at this point
Copy the full SHA 5db158dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6612000 - Browse repository at this point
Copy the full SHA 6612000View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bcbd57 - Browse repository at this point
Copy the full SHA 0bcbd57View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5e56b7 - Browse repository at this point
Copy the full SHA d5e56b7View commit details -
Survey propagation is not well-maintained and is racy, which leads to poor correctness behavior with high concurrency (e.g., increased error, divergence).
Configuration menu - View commit details
-
Copy full SHA for 7b4fc19 - Browse repository at this point
Copy the full SHA 7b4fc19View commit details -
icc fails to compile gtuple due to errors like the following: [...]gtuple.h(77): error: pack expansion does not make use of any argument packs using append = integer_seq<T, Is..., I>; ^ detected during instantiation of class "galois::integer_seq<T, Is...> [with T=int, Is=<>]" at line 104 Similar errors are reported by icc when it compiles <tuple> from the GCC 9 STL library. Currently, icc 12 only supports GCC 8 as a backend. So, it appears that there are some C++17 features that still trip up icc. As a workaround, reformulate gtuple in terms of standard C++17 STL features. Since, gtuple itself was designed to provide transitional support for integer sequences and related functionality in mixed C++11 codebases, this gives us an opportunity to remove custom code.
Configuration menu - View commit details
-
Copy full SHA for ae090e1 - Browse repository at this point
Copy the full SHA ae090e1View commit details -
build: Disable inline warning with icc
icc is very verbose about mismatches between inline, noinline and implicitly inlined methods (like method definitions in class definitions). Disable these warnings. (Apparently, we are not the only ones to do so [1]) [1] https://eigen.tuxfamily.org/dox/DisableStupidWarnings_8h_source.html
Configuration menu - View commit details
-
Copy full SHA for 029c68d - Browse repository at this point
Copy the full SHA 029c68dView commit details -
Previously, there were two different classes for reductions. One for types that are efficiently copyable (GSimpleReducible) and one for types are are expensive to copy (GBigReducible). STL containers manage to deal with inefficient-to-copy elements without resorting to completely separate implementations by using move semantics and adding API adjustments like emplace. This commit does the same. Replace the two reducible classes with a single Reducible class. Reducible tries to use move semantics throughout, which will naturally fall-back to copying if there is no appropriate specialization. Remove the subclasses of GBigReducible, which existed to handle updating container types while avoiding creating large intermediate values. Instead, rely on the getLocal (previously peek_local) method to access the current per-thread value and require clients to manipulate the value directly. This change does lose the clean abstraction property of the previous approach but having wrapper classes for each composition of container types seems unwieldy and difficult for users to understand and extend.
Configuration menu - View commit details
-
Copy full SHA for 681bed0 - Browse repository at this point
Copy the full SHA 681bed0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad72078 - Browse repository at this point
Copy the full SHA ad72078View commit details -
GALOIS_LOW_MEMORY CMAKE option
when set, reduces amount of per thread storage for each thread from default of 32MB per thread; useful for machines with low RAM or for running on CI where memory is limited + multiple processes are spawned
Configuration menu - View commit details
-
Copy full SHA for 1253ea4 - Browse repository at this point
Copy the full SHA 1253ea4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c903e49 - Browse repository at this point
Copy the full SHA c903e49View commit details -
Configuration menu - View commit details
-
Copy full SHA for e76833b - Browse repository at this point
Copy the full SHA e76833bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c7e50ff - Browse repository at this point
Copy the full SHA c7e50ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce78fe5 - Browse repository at this point
Copy the full SHA ce78fe5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72bc380 - Browse repository at this point
Copy the full SHA 72bc380View commit details
Commits on Apr 29, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 083897d - Browse repository at this point
Copy the full SHA 083897dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 168562c - Browse repository at this point
Copy the full SHA 168562cView commit details -
Revert "GALOIS_LOW_MEMORY CMAKE option";
also got rid of mem hack define This reverts commit 1253ea4.
Configuration menu - View commit details
-
Copy full SHA for 50376f0 - Browse repository at this point
Copy the full SHA 50376f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04c79b5 - Browse repository at this point
Copy the full SHA 04c79b5View commit details -
cannot build locally right now so have to test via CI
Configuration menu - View commit details
-
Copy full SHA for ebe0a02 - Browse repository at this point
Copy the full SHA ebe0a02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ac7eec - Browse repository at this point
Copy the full SHA 1ac7eecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 31b2577 - Browse repository at this point
Copy the full SHA 31b2577View commit details
Commits on Apr 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5fd7bac - Browse repository at this point
Copy the full SHA 5fd7bacView commit details -
fix warnings in aigRewriting; only unused functions and veriables use…
…d only by assert left
Configuration menu - View commit details
-
Copy full SHA for 17e1aff - Browse repository at this point
Copy the full SHA 17e1affView commit details -
Configuration menu - View commit details
-
Copy full SHA for 367c346 - Browse repository at this point
Copy the full SHA 367c346View commit details
Commits on May 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 06c4286 - Browse repository at this point
Copy the full SHA 06c4286View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48159f5 - Browse repository at this point
Copy the full SHA 48159f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba0bc71 - Browse repository at this point
Copy the full SHA ba0bc71View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5bd749 - Browse repository at this point
Copy the full SHA d5bd749View commit details
Commits on May 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 79ff6ca - Browse repository at this point
Copy the full SHA 79ff6caView commit details