Adding Latest visit date and Correct TX Curr #50
Conversation
WalkthroughThe pull request introduces modifications to two Java classes: Changes
Sequence DiagramsequenceDiagram
participant GetTxCurr
participant ContextService
participant PatientEnrollmentData
GetTxCurr->>ContextService: Fetch enrollment observations
ContextService-->>GetTxCurr: Return observations
GetTxCurr->>GetTxCurr: Filter patients by enrollment dates
GetTxCurr->>GetTxCurr: Check patient statuses (death, transfer, RTT)
GetTxCurr->>PatientEnrollmentData: Create enrollment data objects
GetTxCurr-->>PatientEnrollmentData: Return filtered patient list
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
omod/src/main/java/org/openmrs/module/ssemrws/web/controller/FormsController.java (1)
103-104: UseDateTimeFormatterinstead ofSimpleDateFormatfor better thread safety and modern API
DateTimeFormatterfrom thejava.timepackage is thread-safe and should be preferred overSimpleDateFormat.Apply this diff to use
DateTimeFormatter:+ import java.time.ZoneId; + import java.time.format.DateTimeFormatter; - SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss"); - String latestVisitDate = dateFormat.format(latestVisit.getStartDatetime()); + DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss"); + String latestVisitDate = latestVisit.getStartDatetime().toInstant().atZone(ZoneId.systemDefault()).format(formatter);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
omod/src/main/java/org/openmrs/module/ssemrws/web/constants/GetTxCurr.java(1 hunks)omod/src/main/java/org/openmrs/module/ssemrws/web/controller/FormsController.java(2 hunks)
| System.out.println("Including Patient: " + patient.getPersonName().getFullName() | ||
| + " due to return to treatment date: " + rttDate); |
There was a problem hiding this comment.
Avoid logging patient names to prevent PII leakage
Logging patient names can lead to exposure of sensitive personal information and violate privacy regulations. Replace System.out.println statements with proper logging and avoid including personal identifiers.
Apply this diff to remove patient names from logs and use a logging framework:
- System.out.println("Including Patient: " + patient.getPersonName().getFullName()
- + " due to return to treatment date: " + rttDate);
+ logger.info("Including patient due to return to treatment date: " + rttDate);Ensure that a logging framework like SLF4J is used and properly configured:
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
private static final Logger logger = LoggerFactory.getLogger(GetTxCurr.class);| System.out.println("Excluding Patient: " + patient.getPersonName().getFullName() | ||
| + " due to exclusion date: " + exclusionDate); |
There was a problem hiding this comment.
Avoid logging patient names to prevent PII leakage
Logging patient names can lead to exposure of sensitive personal information and violate privacy regulations. Replace System.out.println statements with proper logging and avoid including personal identifiers.
Apply this diff to remove patient names from logs and use a logging framework:
- System.out.println("Excluding Patient: " + patient.getPersonName().getFullName()
- + " due to exclusion date: " + exclusionDate);
+ logger.info("Excluding patient due to exclusion date: " + exclusionDate);Committable suggestion skipped: line range outside the PR's diff.
Summary by CodeRabbit
New Features
Refactor