add note about windows DDS popup message #13609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhadMeir
reviewed
Dec 17, 2024
third-party/realdds/readme.md
Outdated
| @@ -61,6 +61,8 @@ Alternatively, one can use RealDDS to bypass librealsense. This will avoid some | |||
|
|
|||
| Or you can directly interact with the DDS subsystem, using any implementation. This bypasses librealsense and RealDDS completely. While the protocol used by RealDDS (the topic structure, message formats, etc.) will likely not change much, it is not guaranteed to stay static in the face of new features or bugs. | |||
|
|
|||
| **Note**: In Windows systems where firewall is enabled, you may see the message "Do you want to allow networks to access this app", make sure to allow this in your network to ensure proper communication with the DDS device. This message shows up since we open and bind a socket when using DDS, and we need to allow our it through the network security settings (a rule to allow our app is added to the firewall rules). | |||
There was a problem hiding this comment.
I am not sure this is Windows only problem. Better to make it more general.
Also a redundant "our" - "need to allow our it through"
OhadMeir
reviewed
Dec 22, 2024
third-party/realdds/readme.md
Outdated
| @@ -61,6 +61,8 @@ Alternatively, one can use RealDDS to bypass librealsense. This will avoid some | |||
|
|
|||
| Or you can directly interact with the DDS subsystem, using any implementation. This bypasses librealsense and RealDDS completely. While the protocol used by RealDDS (the topic structure, message formats, etc.) will likely not change much, it is not guaranteed to stay static in the face of new features or bugs. | |||
|
|
|||
| **Note**: In some systems where firewall is enabled, you may see the message "Do you want to allow networks to access this app", make sure to allow this in your network to ensure proper communication with the DDS device. This message shows up since we open and bind a socket when using DDS, and we need to allow it through the network security settings (a rule to allow our app is added to the firewall rules). | |||
There was a problem hiding this comment.
I would remove the parenthesized sentence (a rule to allow our app is added to the firewall rules). It might be understood that we are adding the rule, which is not the case. Lets just mention that it should be allowed in the network security settings, let the user handle how according to his specific system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on: [RSDEV-2915]