D555 imu record playback #13519
Merged
D555 imu record playback #13519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhadMeir
reviewed
Nov 18, 2024
src/media/ros/ros_reader.cpp
Outdated
| @@ -518,6 +520,24 @@ namespace librealsense | |||
| data[2] = static_cast<float>(msg->angular_velocity.z); | |||
| LOG_DEBUG("RS2_STREAM_GYRO " << motion_frame); | |||
| } | |||
| if (stream_id.stream_type == RS2_STREAM_MOTION) | |||
| { | |||
| auto data = reinterpret_cast<double*>(motion_frame->data.data()); | |||
There was a problem hiding this comment.
Can we cast to const rs2_combined_motion* like the writer?
There was a problem hiding this comment.
Better to use same type for both reading and writing
|
Is this PR depend on FW change? |
OhadMeir
approved these changes
Nov 18, 2024
No, we just did not support the combined motion type in LibRS for recordings. Older FW will work too. |
|
@remibettan, please fix the tests failures before merging. |
remibettan
force-pushed
the
d555_imu_record_playback
branch
from
398a934 to
82b51b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by: RSDEV-2858