Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table read error fallback #13512

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Nov 13, 2024

We wish to allow the camera to enumerate even no flash tables.
image

Tracked on [RSDEV-2874] [RSDEV-2901]

Copy link
Contributor

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sematic comments - great improvement!

@Nir-Az
Copy link
Collaborator Author

Nir-Az commented Nov 14, 2024

Notes from @ev-mp

  1. Can you add a note whether this applies to RGB or Depth sensor intrinsic for clarity?
  2. What is the impact of returning empty intrinsic ? Providing arbitrary values may mask the issue making the user unaware of the actual problem

@Nir-Az
Copy link
Collaborator Author

Nir-Az commented Nov 14, 2024

Notes from @ev-mp

  1. Can you add a note whether this applies to RGB or Depth sensor intrinsic for clarity?
  2. What is the impact of returning empty intrinsic ? Providing arbitrary values may mask the issue making the user unaware of the actual problem
  1. Yes will do
  2. The user will get a log error, if you prefer I can have an internal flag and override the start stream function and throw on this case, not sure it is worth it. thoughts?

Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az merged commit 2fea862 into IntelRealSense:development Nov 14, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants